fix: resolve cross-package test failures and type errors - #91
Open
stooit wants to merge 2 commits into
Open
Conversation
added 2 commits
July 25, 2026 17:53
- api: re-export useSearchDebounce from renamed useDebounce hook - Button: expose aria-label as accessible name on icon-only buttons - DataTable: fix stale-closure bug in re-render handler - date: use day-first locale format without leading zero - tsconfig: resolve bun:test type resolution
Emit a dev console.warn when an icon-only button is rendered without an aria-label, surfacing the WCAG 4.1.2 accessibility gap to developers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all failing tests and type errors across the monorepo. The full suite now passes (13 pass / 0 fail) and
tsc --noEmitis clean.Four cross-package bugs plus a type-config issue were resolved:
apps/web/src/lib/api.ts) —useThrottlewas renamed touseDebouncein@e2e/utilsbut the old name was still imported. Restored theuseSearchDebouncepublic export by re-exporting the renameduseDebouncehook.packages/ui/.../Button.tsx) — icon-only buttons now expose theiraria-labelas an accessible name (WCAG 4.1.2). Also emits a dev-modeconsole.warnwhen an icon-only button is rendered without anaria-label.packages/ui/.../DataTable.tsx) — fixed a stale-closure bug in the re-render handler caught by the controlled re-render test.packages/utils/src/format/date.ts) —formatDatenow uses the correct day-first locale/format so day 1 is not confused with month 1.tsconfig.json) — resolved thebun:testtype resolution error sotsc --noEmitis clean.Verification
```
bun test packages/utils/test packages/ui/test apps/web/test --preload ./packages/ui/test/setup.ts
13 pass, 0 fail
./node_modules/.bin/tsc --noEmit
exit 0
```
Notes / Assumptions
document is not defined.reviewsubagent; the Button empty-label concern it raised was addressed with the dev warning above.